#59 - Consider custom conversion in MappingR2dbcConverter #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauder
requested changes
Mar 14, 2019
|
|
||
| public OutboundRow convert(Person source) { | ||
| OutboundRow row = new OutboundRow(); | ||
| document.put("_d", source.getId()); |
There was a problem hiding this comment.
That should be row.put ...
| * @param value must not be {@literal null}. | ||
| * @return the {@link SettableValue} value for {@code value}. | ||
| */ | ||
| public static SettableValue from(Object value) { |
There was a problem hiding this comment.
This creates an asymmetry I don't like too much. With one argument you have a factory method, with two args you have to use the constructor.
I'd vote for either only factory methods or constructors but not mixing them in the public API.
MappingR2dbcConverter now considers custom conversions for inbound and outbound conversion of top-level types (Row to Entity, Entity to OutboundRow) and on property level (e.g. convert an object to String and vice versa).
mp911de
force-pushed
the
issue/59-apply-conversions
branch
from
d2e7333 to
b68db1b
Compare
schauder
pushed a commit
that referenced
this pull request
Mar 19, 2019
MappingR2dbcConverter now considers custom conversions for inbound and outbound conversion of top-level types (Row to Entity, Entity to OutboundRow) and on property level (e.g. convert an object to String and vice versa). Original pull request: #70.
|
That's merged via 6654db3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MappingR2dbcConverternow considers custom conversions for inbound and outbound conversion of top-level types (Rowto Entity, Entity toOutboundRow) and on property level (e.g. convert an object toStringand vice versa).Related ticket: #59.